[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [elpa] master 54ced08 3/3: Merge remote-tracking branch 'ztree/maste

From: Alexey Veretennikov
Subject: Re: [elpa] master 54ced08 3/3: Merge remote-tracking branch 'ztree/master'
Date: Sat, 13 Jun 2015 22:55:58 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0


Thanks for comments, I've updated the code to use lexical-binding, updated remaining function names and removed (redundant) newline-and-begin, replacing it with (insert "\n").


On 13/06/15 16:23, Stefan Monnier wrote:
-;; Compatibility: GNU Emacs GNU Emacs 24.x
+;; Compatibility: GNU Emacs 24.x
So is it OK if I change those files to use lexical-binding?

  (defun newline-and-begin ()
    "Move a point to the beginning of the next line."
-  (newline)
+  (insert "\n")
The beginning-of-line can be removed as well (at which point you're
better off removing newline-and-begin altogether and simply replace every
call by (insert "\n")).
One more thing: I see that ztree-util.el defines several functions (such
as the one here) without a "ztree-" prefix.  It would be good to fix this.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]