Re: [Emacs-diffs] master d7df36e: Rewrite elisp--xref-find-definitions to handle many more cases; add tests.

[Dmitry Gutov]

On 08/12/2015 10:40 AM, Stephen Leake wrote:

> (provide 'foo) is the closest thing in elisp syntax. We could jump
> to the ;;; Code: comment.

The first line looks like ;;; elisp-mode.el ---

One could also say it's the package declaration.

> For a better reason, sometimes it does matter what happens in the file
> after (provide 'foo), so that's sometimes a useful place to go.

I wonder how often that is. In most other cases, I think the user will 
be stumped to see Emacs navigate there.

> > If it's not right, M-< is not too far away (or M->, as per below).
>
> and M-. to jump to the function is also not too far away.

We'd have pressed it already by then, didn't we?

> C-u should strip the text properties.

I guess so.

> I will ask first about code I don't understand in the future.

Thank you.

> Did you find my comments clear enough?

I think so. Did you forget to do a push? The recent change only handles 
cl-struct constructor, but not defconst/defvar or the minor mode 
duplication.