emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: find-file-project


From: Stephen Leake
Subject: Re: find-file-project
Date: Tue, 15 Sep 2015 22:34:19 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (windows-nt)

Stephen Leake <address@hidden> writes:

> Stephen Leake <address@hidden> writes:
>
>> Dmitry Gutov <address@hidden> writes:
>>
>>>> +  ;; FIXME: do we need both project-ignores and 
>>>> project-ignore-files-globs?
>>>
>>> Just having project-ignores should suffice.
>>
>> I guess I could just ignore 'dir' in project-ignores. 
>
> On the other hand, if some implementation of project-ignores does not
> ignore the `dir' argument, then the predicate in project-find-file must
> call project-ignores for each dir.
>

Similarly, project-recursive-ignores-to-flat should call project-ignores
for each dir, rather than using a simple ignore-dirs list. Which would
eliminate the need for project-ignore-dirs.

But that is much more complicated, so I'd rather remove the `dir'
argument from project-ignores, if it is not needed for some known use
case.

-- 
-- Stephe



reply via email to

[Prev in Thread] Current Thread [Next in Thread]