|
From: | Przemysław Wojnowski |
Subject: | Re: Separating obarray handling from abbrevs |
Date: | Sun, 08 Nov 2015 22:17:36 +0100 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) |
Artur Malabarba <address@hidden> writes: >> +(defun obarray-make (&optional size) >> + "Return a new obarray of size `SIZE' or `obarray-default-size'." > > Use SIZE, not `SIZE'. Similarly everywhere else. Are you sure about that? With them comments look happier and obarray-default-size becomes a link in Help buffer. Flycheck is also happy. >> +(defun obarray-get (obarray name) >> + "Return from obarray `OBARRAY' symbol with `NAME' or nil." > > I'd use: > "Return symbol named NAME if it is contained in OBARRAY. > Return nil otherwise." > > And I would repeat this throughout the docstrings. Will do that. >> +(defun obarray-put (obarray name) >> + "Return form `OBARRAY' symbol with `NAME' or nil. > > Why the nil? It's a bug. I was just too fast and too furious when writing this. ;-)
[Prev in Thread] | Current Thread | [Next in Thread] |