[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 353f5e7: * lisp/progmodes/verilog-mode.el: Use with-silent-mo
|
From: |
John Wiegley |
|
Subject: |
Re: master 353f5e7: * lisp/progmodes/verilog-mode.el: Use with-silent-modifications |
|
Date: |
Mon, 16 Nov 2015 16:16:27 -0800 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (darwin) |
>>>>> Katsumi Yamaoka <address@hidden> writes:
> Maybe the backquotes nesting in verilog-save-buffer-state is
> unreasonable. I used the following makeshift to pass the build:
> --- verilog-mode.el~ 2015-11-15 21:55:40.234433900 +0000
> +++ verilog-mode.el 2015-11-16 00:55:57.518294500 +0000
> @@ -3239,3 +3239,4 @@
> ,(if (fboundp 'with-silent-modifications)
> - (with-silent-modifications ,@body)
> + (eval (cons 'with-silent-modifications
> + (mapcar (lambda (x) (list 'quote x)) body)))
> ;; From c-save-buffer-state
The ,@body interpolation didn't work because it wasn't in a backqouted form.
The equivalent should have been: (apply #'with-silent-modifications body) to
execute it immediately, or `(with-silent-modifications ,@body), which should
be equivalent to what you wrote.
John