emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] scratch/follow e8937de: Replace GROUP argument in six


From: Juri Linkov
Subject: Re: [Emacs-diffs] scratch/follow e8937de: Replace GROUP argument in six window primitives by new functions.
Date: Wed, 16 Dec 2015 02:39:08 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (x86_64-pc-linux-gnu)

> Any objections to me merging (or rebasing) this into the emacs-25
> branch?  I think it's ready.

Thanks, Alan.  I have only a small remark: the function name
‘recenter-group’ is too ambiguous.  Adding ‘window-group’
somewhere inside its name would help to narrow its scope, e.g.
‘window-group-recenter’, or ‘recenter-window-group’, or
‘recenter-in-window-group’ by analogy with ‘pos-visible-in-window-group-p’.

And one question: are the functions follow-window-start,
follow-set-window-start, etc. too specific to follow-mode,
or it would be possible to generalize and move them to window.el
leaving only ‘follow-all-followers’ as a follow-specific function?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]