emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: emacs-25 2460cfa: * doc/lispref/lists.texi (Association Lists): Docu


From: John Wiegley
Subject: Re: emacs-25 2460cfa: * doc/lispref/lists.texi (Association Lists): Document 'alist-get'.
Date: Fri, 22 Jan 2016 09:50:28 -0800
User-agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/24.5 (darwin)

>>>>> Michael Heerdegen <address@hidden> writes:

> Do you really think we should add a comment like that to the code? To
> understand the definition, it's better to have a look at gv.el. After having
> had a look, such a comment is not necessary anymore, since we have a more or
> less trivial usage of `gv-letplace'.

Well, some comment would have been nice; compare Eli's reaction, knowing he's
a well seasoned Elisp developer. At the very least, a docstring that makes it
obvious what the code is intending to accomplish. And `gv-letplace' is still a
name that should be changed. Maybe `let-getf-setf'?

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2



reply via email to

[Prev in Thread] Current Thread [Next in Thread]