[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Is it time to drop ChangeLogs?
From: |
Eli Zaretskii |
Subject: |
Re: Is it time to drop ChangeLogs? |
Date: |
Tue, 08 Mar 2016 17:57:41 +0200 |
> From: Óscar Fuentes <address@hidden>
> Date: Tue, 08 Mar 2016 05:23:46 +0100
>
> >> Introduce code reviews. Don't give commit access to the "golden"
> >> branches to everyone, just to a few top contributors and reviewers.
> >
> > We don't have manpower for that.
>
> I find perplexing that we have manpower for reviewing ChangeLogs but not
> for reviewing commit logs *instead*.
I'm surprised that you find it perplexing.
Log messages are much shorter than code diffs, and much simpler to
read and understand. It takes a few seconds to read them; reading a
code patch takes much more, typically needs to consult the surrounding
and related code, etc. So code review takes orders of magnitude more
time than reviewing the corresponding log entries.
> And is it so super-important to have typo-free commit logs?
Typos is the least of our problems. But yes, it's important: if you
start by forgiving typos, you end with unhelpful and uninformative log
messages.
> We are not even using `git notes'.
No one came up with a detailed procedure for doing that. If you can
propose something that works, please do.
- Re: Code reviews, (continued)
- Re: Code reviews, Eli Zaretskii, 2016/03/08
- Re: Code reviews, Phillip Lord, 2016/03/09
- Re: Code reviews, Andreas Röhler, 2016/03/10
- Re: Code reviews (was: Is it time to drop ChangeLogs?), Eli Zaretskii, 2016/03/08
- Re: Code reviews, Stefan Monnier, 2016/03/08
- Re: Code reviews, Eli Zaretskii, 2016/03/08
- Re: Is it time to drop ChangeLogs?, Eli Zaretskii, 2016/03/07
- Re: Is it time to drop ChangeLogs?, Óscar Fuentes, 2016/03/07
- Re: Is it time to drop ChangeLogs?,
Eli Zaretskii <=
- Re: Is it time to drop ChangeLogs?, Nikolaus Rath, 2016/03/08
- Re: Is it time to drop ChangeLogs?, Óscar Fuentes, 2016/03/08
- Re: Is it time to drop ChangeLogs?, David Caldwell, 2016/03/08
- Re: Is it time to drop ChangeLogs?, Dmitry Gutov, 2016/03/08
- Re: Is it time to drop ChangeLogs?, John Wiegley, 2016/03/08
- Re: Is it time to drop ChangeLogs?, Dmitry Gutov, 2016/03/08
- Re: Is it time to drop ChangeLogs?, Giuseppe Scrivano, 2016/03/08
- Re: Is it time to drop ChangeLogs?, David Caldwell, 2016/03/08
- Re: Is it time to drop ChangeLogs?, Dmitry Gutov, 2016/03/08
- Re: Is it time to drop ChangeLogs?, Óscar Fuentes, 2016/03/08