[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: emacs-25 b6b47AF: Properly encode/decode base64Binary data in SOAP
From: |
Stefan Monnier |
Subject: |
Re: emacs-25 b6b47AF: Properly encode/decode base64Binary data in SOAP |
Date: |
Sun, 13 Mar 2016 11:15:23 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) |
>>> The interface does not return bytes, it returns a (half-)decoded lisp
>>> form.
>> My understanding is that it returns a structure whose leaves are
>> all byte-strings because.
> String values are returned as multibyte, e.g.:
> (multibyte-string-p (cdr (assq 'severity (car (debbugs-get-status 22285)))))
> => t
> because parsing happens in a temporary buffer where
> enable-multibyte-characters is set, and the string value is returned
> unchanged.
If these are undecoded, then I'd consider it a bug to return them as
multibyte, indeed. The temp buffer should probably be made unibyte.
> this nuance of the API. Also, on the encoding side I think we should
> force the caller to provide unibyte strings for base64Binary values.
I'd let base64-encode-string make that decision, but it's just my own
preference of bikeshed's color.
> Is the attached patch OK for master and emacs-25?
Looks OK to me for master. I'll let others figure out if it's safe
enough for `emacs-25'.
Stefan
- Re: emacs-25 b6b47af: Properly encode/decode base64Binary data in SOAP, Thomas Fitzsimmons, 2016/03/09
- Re: emacs-25 b6b47af: Properly encode/decode base64Binary data in SOAP, Andreas Schwab, 2016/03/10
- Re: emacs-25 b6b47AF: Properly encode/decode base64Binary data in SOAP, Thomas Fitzsimmons, 2016/03/10
- Re: emacs-25 b6b47AF: Properly encode/decode base64Binary data in SOAP, Andreas Schwab, 2016/03/11
- Re: emacs-25 b6b47AF: Properly encode/decode base64Binary data in SOAP, Alex Harsanyi, 2016/03/11
- Re: emacs-25 b6b47AF: Properly encode/decode base64Binary data in SOAP, Andreas Schwab, 2016/03/11
- Re: emacs-25 b6b47AF: Properly encode/decode base64Binary data in SOAP, Stefan Monnier, 2016/03/11
- Re: emacs-25 b6b47AF: Properly encode/decode base64Binary data in SOAP, Andreas Schwab, 2016/03/11
- Re: emacs-25 b6b47AF: Properly encode/decode base64Binary data in SOAP, Stefan Monnier, 2016/03/11
- Re: emacs-25 b6b47AF: Properly encode/decode base64Binary data in SOAP, Thomas Fitzsimmons, 2016/03/12
- Re: emacs-25 b6b47AF: Properly encode/decode base64Binary data in SOAP,
Stefan Monnier <=
- Re: emacs-25 b6b47AF: Properly encode/decode base64Binary data in SOAP, Thomas Fitzsimmons, 2016/03/13
- Re: emacs-25 b6b47AF: Properly encode/decode base64Binary data in SOAP, Eli Zaretskii, 2016/03/13
- Re: emacs-25 b6b47AF: Properly encode/decode base64Binary data in SOAP, Thomas Fitzsimmons, 2016/03/13
- Re: emacs-25 b6b47AF: Properly encode/decode base64Binary data in SOAP, Eli Zaretskii, 2016/03/13
- Re: emacs-25 b6b47AF: Properly encode/decode base64Binary data in SOAP, Thomas Fitzsimmons, 2016/03/13
- Re: emacs-25 b6b47AF: Properly encode/decode base64Binary data in SOAP, Eli Zaretskii, 2016/03/13
- Re: emacs-25 b6b47AF: Properly encode/decode base64Binary data in SOAP, Thomas Fitzsimmons, 2016/03/13
- Re: emacs-25 b6b47AF: Properly encode/decode base64Binary data in SOAP, Eli Zaretskii, 2016/03/13
- Re: emacs-25 b6b47AF: Properly encode/decode base64Binary data in SOAP, Andreas Schwab, 2016/03/14
- Re: emacs-25 b6b47AF: Properly encode/decode base64Binary data in SOAP, Michael Albinus, 2016/03/14