[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/5] Add systemd socket launching support.
From: |
Eli Zaretskii |
Subject: |
Re: [PATCH 0/5] Add systemd socket launching support. |
Date: |
Sun, 27 Mar 2016 18:23:32 +0300 |
> From: Matthew Leach <address@hidden>
> Cc: address@hidden
> Date: Sun, 27 Mar 2016 16:17:38 +0100
>
> >> * src/process.c (connect_network_socket): Allow a systemd-allocated
> >> file-descriptor to be passed, and use it, avoiding the call to
> >> socket() and bind().
> >> (Fmake_network_process): Allow users to pass in :systemd-fd on the
> >> parameter plist to use a systemd fd.
> >> (wait_reading_process_output): Call socket() & bind() every time.
> >
> > I'm not sure I understand the rationale for this design. Why do we
> > need to drag the systemd socket through all the APIs, including
> > exposing its value to Lisp(!), when it is stored in an internal
> > variable that can be easily accessed by the low-level network-related
> > functions? Why cannot we instead provide a boolean flag that just
> > tells these low-level functions to use that socket?
>
> Indeed, that does seem like a better approach. I'm guessing the flag
> you refer to should be passed to make_network_process from server-start?
Yes.
Thanks.
Re: [PATCH 0/5] Add systemd socket launching support., Eli Zaretskii, 2016/03/27