[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
FACE_FROM_ID vs FACE_OPT_FROM_ID
From: |
Eli Zaretskii |
Subject: |
FACE_FROM_ID vs FACE_OPT_FROM_ID |
Date: |
Thu, 23 Jun 2016 23:03:52 +0300 |
Paul, can you explain why we need two macros where we had only one?
Two macros with similar effect and unclear rules for when to use each
one doesn't sound like a good idea to me. I've read the commit log
message, which attempts to explain the preference, but I don't think I
understand the criterion -- any face ID can cause FACE_FROM_ID to
produce NULL, if called in some inopportune moment. I also looked at
the places where you used each macro, and I cannot understand why you
decided to use this or that, maybe I'm missing something.
What was the GCC 6.1 complaint that led you to this change?
Same questions for IMAGE_FROM_ID.
- FACE_FROM_ID vs FACE_OPT_FROM_ID,
Eli Zaretskii <=
- Re: FACE_FROM_ID vs FACE_OPT_FROM_ID, Paul Eggert, 2016/06/23
- Re: FACE_FROM_ID vs FACE_OPT_FROM_ID, Eli Zaretskii, 2016/06/24
- Re: FACE_FROM_ID vs FACE_OPT_FROM_ID, Paul Eggert, 2016/06/24
- Re: FACE_FROM_ID vs FACE_OPT_FROM_ID, Eli Zaretskii, 2016/06/24
- Re: FACE_FROM_ID vs FACE_OPT_FROM_ID, Eli Zaretskii, 2016/06/24
- Re: FACE_FROM_ID vs FACE_OPT_FROM_ID, Paul Eggert, 2016/06/24
- Re: FACE_FROM_ID vs FACE_OPT_FROM_ID, Eli Zaretskii, 2016/06/24
- Re: FACE_FROM_ID vs FACE_OPT_FROM_ID, Paul Eggert, 2016/06/24
- Re: FACE_FROM_ID vs FACE_OPT_FROM_ID, Eli Zaretskii, 2016/06/25
- Re: FACE_FROM_ID vs FACE_OPT_FROM_ID, Paul Eggert, 2016/06/25