Re: [Emacs-diffs] master 5811404: Replace eldoc-documentation-function with a hook

[Mark Oteiza]

On 07/07/16 at 12:31pm, John Wiegley wrote:
> >>>>> Stefan Monnier <address@hidden> writes:
>
> > I thought it was agreed that it would be a bad idea.
>
> I was asked in IRC about this patch, and I couldn't see anything objectionable
> about it. However, clearly I was unaware of previous discussion on the matter.
> Mark, could you please revert until we have more consensus that we want to do
> this?  Thank you.

Commit fd020a29[0] was implemented only to make it possible for the default
value to be used, something hooks already do.  See Bug#19338.

It is unclear what discussion you are talking about.  Perhaps it's
here[1], but if not, I hope you will read it before asking me to make
more commit noise.  One could refer to a number of sources for developer
opinion on using advice in core, but perhaps it is best to quote the
Elisp manual:

     […] advice should be reserved for the cases where you cannot modify
     a function’s behavior in any other way.  If it is possible to do
     the same thing via a hook, that is preferable (see Hooks).  […] In
     particular, Emacs’s own source files should not put advice on
     functions in Emacs.  (There are currently a few exceptions to this
     convention, but we aim to correct them.)

[0] http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=fd020a29
[1] https://lists.gnu.org/archive/html/emacs-devel/2016-06/msg00138.html