[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Compilation warnings in mouse.el
From: |
Stefan Monnier |
Subject: |
Re: Compilation warnings in mouse.el |
Date: |
Tue, 12 Jul 2016 18:58:12 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) |
EZ> Unlike Stefan, I think we should add :group to every defcustom. Having
EZ> them mysteriously missing from some of them is a time bomb:
The way I see it, defcustoms should pretty much never have :group, and
the group to which they belong is simply determined by the file in which
they occur.
E.g. the `mouse' group should be defined in mouse.el rather than in
cus-edit.el, which would have solved this problem.
EZ> remove or add
EZ> enough defcustoms in the same file, and you have a bug.
I don't see how removing/adding defcustoms in the same file
would introduce problems.
Stefan
PS: Incidentally, we have two definitions of the `mouse' group
in cus-edit.el:
% grep -A2 '(defgroup mouse ' **/*.el
lisp/cus-edit.el:(defgroup mouse nil
lisp/cus-edit.el- "Mouse support."
lisp/cus-edit.el- :group 'editing)
--
lisp/cus-edit.el:(defgroup mouse nil
lisp/cus-edit.el- "Input from the mouse."
lisp/cus-edit.el- :group 'environment)
%
- Compilation warnings in mouse.el, Eli Zaretskii, 2016/07/11
- Re: Compilation warnings in mouse.el, Stephen Berman, 2016/07/11
- Re: Compilation warnings in mouse.el, Eli Zaretskii, 2016/07/12
- Re: Compilation warnings in mouse.el, Stephen Berman, 2016/07/12
- RE: Compilation warnings in mouse.el, Drew Adams, 2016/07/12
- Re: Compilation warnings in mouse.el, John Wiegley, 2016/07/12
- Re: Compilation warnings in mouse.el,
Stefan Monnier <=
- Re: Compilation warnings in mouse.el, Joost Kremers, 2016/07/13
- Re: Compilation warnings in mouse.el, Stefan Monnier, 2016/07/13
- RE: Compilation warnings in mouse.el, Drew Adams, 2016/07/13
- Re: Compilation warnings in mouse.el, Eli Zaretskii, 2016/07/13
- Re: Compilation warnings in mouse.el, Stefan Monnier, 2016/07/13
- RE: Compilation warnings in mouse.el, Drew Adams, 2016/07/13
- Re: Compilation warnings in mouse.el, Stefan Monnier, 2016/07/13
- RE: Compilation warnings in mouse.el, Drew Adams, 2016/07/13
- Re: Compilation warnings in mouse.el, Eli Zaretskii, 2016/07/13
- Re: Compilation warnings in mouse.el, Stefan Monnier, 2016/07/13