Re: [PATCH] url: Wrap cookie headers in url-http--encode-string.

emacs-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] url: Wrap cookie headers in url-http--encode-string.

From:	Eli Zaretskii
Subject:	Re: [PATCH] url: Wrap cookie headers in url-http--encode-string.
Date:	Sat, 10 Sep 2016 08:42:35 +0300

> From: Toke Høiland-Jørgensen <address@hidden>
> Cc: Alain Schneble <address@hidden>, address@hidden, address@hidden,
>       address@hidden
> Date: Fri, 09 Sep 2016 21:56:44 +0200
> 
> > It wouldn't be safe if cookies could include non-ASCII characters.
> 
> Well, according to this:
> 
> http://stackoverflow.com/a/1969339
> 
> Safari, at least, will reject non-ASCII cookies. Which implies that in
> practice no sites will use non-ASCII values because they would break.

Then your original patch should be fine for the emacs-25 branch.  If
no objections are voiced here by the end of the day, I think we should
install it.

Thanks.

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH] url: Wrap cookie headers in url-http--encode-string., (continued)
- Re: [PATCH] url: Wrap cookie headers in url-http--encode-string., Lars Ingebrigtsen, 2016/09/07
  - Re: [PATCH] url: Wrap cookie headers in url-http--encode-string., Toke Høiland-Jørgensen, 2016/09/07
  - Re: [PATCH] url: Wrap cookie headers in url-http--encode-string., Eli Zaretskii, 2016/09/07

Prev by Date: font-lock-constant-face in 1-char length labels
Next by Date: Re: distinguishing multibyte/unibyte ASCII (was: [PATCH] url: Wrap cookie headers in url-http--encode-string.)
Previous by thread: Re: [PATCH] url: Wrap cookie headers in url-http--encode-string.
Next by thread: Re: [PATCH] url: Wrap cookie headers in url-http--encode-string.
Index(es):
- Date
- Thread