[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Ibuffer: w and B default to buffer at current line

From: John Wiegley
Subject: Re: Ibuffer: w and B default to buffer at current line
Date: Tue, 13 Sep 2016 23:41:04 -0700
User-agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1 (darwin)

>>>>> "TC" == Tino Calancha <address@hidden> writes:

TC> * lisp/ibuffer.el (ibuffer-get-marked-buffers):
TC> Add an optional parameter BUFFER-AT-LINE: if non-nil and
TC> there are no marked buffers, return the buffer at current line.

Hi Tino,

I don't like this part of your proposed change. The name of the function is
`ibuffer-get-marked-buffers'. Adding a new argument to change the meaning of
the function is not a good idea.

Instead, there should be a new function `ibuffer-get-buffer-at-point' or some
such, to reflect the meaning you wish to express. There may even already be
such a function, I'm not all that familiar with ibuffer.el.

TC> Ibuffer: 'w' and 'B' default to the buffer at current line.
TC> This is similar as dired-copy-filename-as-kill.
TC> Before this patch, when there are no marked buffers
TC> these commands signal an error:

This part sounds reasonable to me. I like the idea of defaulting behavior when
there is no current selection or region.

John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]