[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: unexmacosx.c and limits.h problem

From: Eli Zaretskii
Subject: Re: unexmacosx.c and limits.h problem
Date: Sat, 17 Sep 2016 16:38:28 +0300

> From: Richard Copley <address@hidden>
> Date: Sat, 17 Sep 2016 13:56:03 +0100
> Cc: Paul Eggert <address@hidden>, Bob Halley <address@hidden>, 
>       Emacs Development <address@hidden>
> > I added an #error to limits.h; as you can see from the output below,
> > limits.h is already included via the system stdlib.h, which is
> > included near the top of w32proc.c, so the direct #include of limits.h
> > after config.h in w32proc.c has no effect.
> >
> > In file included from
> > C:/msys64/mingw64/x86_64-w64-mingw32/include/stdlib.h:10:0,
> >                  from G:/emacs/repo/emacs/src/w32proc.c:27:
> > ../lib/limits.h:21:2: error: #error limits
> >  #error limits
> >   ^~~~~
> This is similar to what Bob said in his original message,
> > The reason other code works is because it #include <config.h> which
> > defines it before including <limits.h>, but unexmacosx.c includes
> > <stdlib.h> before > including <config.h> for reasons it describes,
> > and this causes <limits.h> to get included as well.

Which to me sounds like lib/limits.h is not a good place to define
these constants, or at least Emacs shouldn't rely on Gnulib's limits.h
to do its magic on all systems.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]