[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] lexical-binding mega-patch (was: Re: [Emacs-diffs] master 05
From: |
Mark Oteiza |
Subject: |
Re: [PATCH] lexical-binding mega-patch (was: Re: [Emacs-diffs] master 05dc679: Turn on lexical-binding in json.el) |
Date: |
Wed, 28 Sep 2016 13:17:20 -0400 |
User-agent: |
Mutt/1.7+23 (87911ba95dae) (2016-08-17) |
On 13/08/16 at 09:31pm, Eli Zaretskii wrote:
> > Date: Sat, 13 Aug 2016 14:18:32 -0400
> > From: Mark Oteiza <address@hidden>
> > Cc: address@hidden, John Wiegley <address@hidden>,
> > Eli Zaretskii <address@hidden>
> >
> > On 10/08/16 at 10:36pm, Stefan Monnier wrote:
> > > > Seems like a lot of low hanging fruit to pick and I should post
> > > > a patch, WDYT?
> > >
> > > Go for it.
> >
> > Done. Flipped the switch and fixed small warnings on files in
> > lisp/*.el, but didn't bother with fixing other kinds of warnings or
> > altering libs actually using dynamic binding or didn't already have
> > a compile-time dependency on cl{,-lib} for {,cl-}pushnew. Nothing
> > appears to be broken, but AFAIK I don't make regular use of many of
> > these libraries.
>
> IMO, we should have tests for each one of them before we do this.
>
> Thanks.
Did the above in cbb2e84518 for files that already had tests written.
Tests passed.
- Re: [PATCH] lexical-binding mega-patch (was: Re: [Emacs-diffs] master 05dc679: Turn on lexical-binding in json.el),
Mark Oteiza <=