Re: [Emacs-diffs] master 2c8a7e5: Improve diff-mode navigation/manipulation

[Mark Oteiza]

Fixing C-c C-a to DTRT is great, thanks, but I don't think the
off-by-one navigation changes to "n" and "p" (diff-hunk-next,
diff-hunk-prev) make sense. While it may have made fixing the issues
mentioned in the commit message easier, the changes to what "n" and "p"
do at the beginning and end of a diff are not documented, and I didn't
see any discussion of it in the associated bug.

I contend that the new behavior is inconsistent with the behavior of
other outline/thing-with-headers type things in Emacs.  outline-mode,
org-mode, and rst-mode are the first ones that come to mind.

It's also not clear how the introduced oddity with auto-refine is going
to be resolved, unless a way is found to autorefine the first hunk
without there being any user interaction.  Then opening a diff has
inconsistent auto-refining from the start.