[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: block_input for some APIs
|
From: |
Eli Zaretskii |
|
Subject: |
Re: block_input for some APIs |
|
Date: |
Tue, 13 Dec 2016 05:46:47 +0200 |
> From: Daniel Colascione <address@hidden>
> Date: Mon, 12 Dec 2016 13:53:33 -0800
> Cc: address@hidden
>
> That said, the existing calls to block_input don't do a lot of harm, so
> there's no need to remove them.
They make the code trickier to read and understand, because
block_input, unblock_input, and input_blocked_p are not thread-safe.
It took me a while to convince myself they are not an issue with the
current concurrency design, except in xgselect.c, and I'm still not
sure my conclusion is 100% valid.