[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Killing frame-locals (was: [Emacs-diffs] master 88fefc3 7/7: ; Merge
From: |
Noam Postavsky |
Subject: |
Re: Killing frame-locals (was: [Emacs-diffs] master 88fefc3 7/7: ; Merge: Lisp watchpoints (Bug#24923)) |
Date: |
Sat, 17 Dec 2016 09:59:56 -0500 |
On Sat, Dec 17, 2016 at 9:31 AM, Stefan Monnier
<address@hidden> wrote:
> Ping?
>
> I'll take care of the patch, if we agree,
>
>
> Stefan
>
>
>>>>>> "Stefan" == Stefan Monnier <address@hidden> writes:
>
>>> + else if (sym->redirect == SYMBOL_LOCALIZED
>>> + && SYMBOL_BLV (sym)->frame_local)
>>> + xsignal1 (Qtrapping_frame_local, symbol);
>
>> BTW, make-variable-frame-local has been declared obsolete since
>> Emacs-22.2, so I think now is a good time to get rid of
>> frame-local variables.
>
I did a web search for make-variable-frame-local, I found only
perspective-el still using it. I think it's a fairly popular package;
on the other hand, it's not in GNU ELPA, and it's not like they didn't
have warning in advance...
https://github.com/nex3/perspective-el/blob/1.12/perspective.el#L194-L197
;; make-variable-frame-local is obsolete according to the docs,
;; but I don't want to have to manually munge frame-parameters
;; all the time so I'm using it anyway.
(make-variable-frame-local