Re: [Emacs-diffs] master 61f8c23 1/2: Minor advice.el fix

[Stefan Monnier]

> For some of them definitely. I'd draw the line between pure functions like
> car and eq, where those facilities never make sense and would be
> ineffective anyway as the functions are compiled away or called directly,
> and impure functions like call-process, where fset is necessary for
> mocking. As a rule of thumb, I'd suggest to ban fset on all symbols that
> have a byte-code equivalent, and on constant symbols.

I still very doubt that the potential benefit is worth the added cost
(more specifically, as a maintainer I would strongly oppose such
measure).  Are you also going to try and prevent the user from using all
the other ways he can shoot himself in the foot?


        Stefan