[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] master 1b4442b: Don't expand body inside a let-binding
From: |
Mark Oteiza |
Subject: |
Re: [Emacs-diffs] master 1b4442b: Don't expand body inside a let-binding when there are no bindings |
Date: |
Fri, 17 Feb 2017 19:10:25 -0500 |
User-agent: |
Mutt/1.7.2+46 (7c97a8af8718) (2016-11-26) |
On 17/02/17 at 07:05pm, Stefan Monnier wrote:
> > In the past I noticed that pcase expanded things to (let nil ...), which
> > I think is a bit annoying wrt readability, yes; however just recently I
> > was poking at elint.el, which complains about such forms with
> >
> > Empty varlist in let: (let nil <snip>)
> >
> > so I was more inclined to change it.
>
> OK, thanks.
>
> > Between vars possibly being expensive, and--one step beyond that--using an
> > uninterned symbol to ameliorate evalling vars twice incurring a cost
> > with dynamic binding, I suppose this change was short sighted.
>
> Sorry, I didn't understand this part of your message.
I was pondering not sending the last part because I was suddenly getting
really tired. As long as the change is okay I guess it doesn't matter.
Woops.