[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Dynamic modules: MODULE_HANDLE_SIGNALS etc.

From: Philipp Stephani
Subject: Re: Dynamic modules: MODULE_HANDLE_SIGNALS etc.
Date: Sun, 26 Mar 2017 20:18:16 +0000

Philipp Stephani <address@hidden> schrieb am So., 20. Dez. 2015 um 22:00 Uhr:
Eli Zaretskii <address@hidden> schrieb am So., 20. Dez. 2015 um 19:59 Uhr:
> From: Philipp Stephani <address@hidden>
> Date: Sun, 20 Dec 2015 18:27:19 +0000
> Cc: address@hidden, address@hidden, address@hidden,
>       address@hidden, address@hidden
>     and did you make sure
>     that signaling an error from a module still reports the same
>     information and backtrace as before the change?
> No, but I wouldn't know how the patch should change this. It only changes an
> implementation detail in the error reporting code of the module implementation
> itself.

I provided one such test here:


and the resulting backtrace here:


> If we wanted to check the backtrace, I think we should rather add a unit test
> for it.

That would be good, thanks.

Added a patch to that effect. 

Pushed to master as 05bfebfc91. 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]