[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] master 085c7f6 2/2: Test format-time-string with zone

From: Eli Zaretskii
Subject: Re: [Emacs-diffs] master 085c7f6 2/2: Test format-time-string with zone arg
Date: Tue, 02 May 2017 09:29:35 +0300

> Cc: address@hidden, address@hidden
> From: Paul Eggert <address@hidden>
> Date: Mon, 1 May 2017 16:05:21 -0700
> On 05/01/2017 12:36 PM, Eli Zaretskii wrote:
> > Thanks.  This version still has problems in the MinGW build:
> Oh my, I wasn't aware that MinGW timezones were so limited.

More accurately, the support for the timezone specs via the TZ
environment variable is very limited.  The native Windows way of
specifying timezones is as rich as that on Posix systems, but it uses
programmatic APIs, not environment variables or databases stored on

> I installed the attached to try to fix the test accordingly.

Thanks, all the tests now pass.

However, the utimens.c file you've brought from Gnulib has 2 problems:

  . it defines WIN32_LEAN_AND_MEAN unconditionally, which conflicts
    with our own definition in nt/inc/ms-w32.h, which is processed

  . it includes msvc-nothrow.h, which is absent in the repository, it
    should have been imported from Gnulib together with utimens.c

I fixed the first of these temporarily, in a way that at least GCC
lets utimens.c compile, but I think in general utimens.c should do

  #ifndef WIN32_LEAN_AND_MEAN
  # define WIN32_LEAN_AND_MEAN

to avoid possible clashes with definitions elsewhere in the sources.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]