[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Trimming strings, /emacs/lisp/emacs-lisp/subr-x.el modification

From: Jean-Christophe Helary
Subject: Re: Trimming strings, /emacs/lisp/emacs-lisp/subr-x.el modification
Date: Wed, 3 May 2017 07:35:18 +0900

> On May 3, 2017, at 0:41, Clément Pit-Claudel <address@hidden> wrote:
> Looks good.  The stirng could be called string-trim-regexp (no need for 
> default), though, I think.

I copied the name pattern from subr.el (split-string). I have no strong opinion 
about names but I thought it was good to keep some consistency between similar 
functions (although I understand that not all default values are named 


> On 2017-05-02 05:34, Jean-Christophe Helary wrote:
>> Following the discussion about how trimming in subr-x.el did not allow for 
>> non-default regex, I have this small modification to the 3 trimming 
>> functions found therein.
>> Basically:
>> 1) I extracted the default regex and assigned it to string-trim-default-regex

reply via email to

[Prev in Thread] Current Thread [Next in Thread]