[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] master 1c9c02f: Tweak dns-mode font-lock

From: Stefan Monnier
Subject: Re: [Emacs-diffs] master 1c9c02f: Tweak dns-mode font-lock
Date: Fri, 05 May 2017 16:28:00 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux)

>  (defcustom dns-mode-font-lock-keywords
>    `(("^$ORIGIN" 0 ,dns-mode-control-entity-face)
>      ("^$INCLUDE" 0 ,dns-mode-control-entity-face)
> +    ("^$TTL" 0 ,dns-mode-control-entity-face)
>      ("^$[a-z0-9A-Z]+" 0 ,dns-mode-bad-control-entity-face)
>      (,(regexp-opt dns-mode-classes) 0 ,dns-mode-class-face)
>      (,(regexp-opt dns-mode-types) 0 ,dns-mode-type-face))

BTW, these rules look weird: they mean that the
dns-mode-(control-entity|class|type)-face variables hold *expressions*
whose value is a face, whereas they docstrings say "Name of face...".

E.g. I'm pretty sure users would expect

    (setq dns-mode-class-face 'bold)

to do something like show classes in bold, whereas it will likely result
in errors saying that `bold` is a void-variable.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]