[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Clean up a couple of compiler warnings

From: Paul Eggert
Subject: Re: [PATCH] Clean up a couple of compiler warnings
Date: Sun, 21 May 2017 13:33:44 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1

Philipp Stephani wrote:
This apparently hasn't worked, at least I still get the warning, and
there's no -Wno-missing-braces in WARN_CFLAGS.

My change didn't add -Wno-missing-braces; it removed -Wmissing-braces. This sufficed for Fedora 25 x86-64, which has clang 3.9.1.

Perhaps you're running a different version of Clang, which is pickier? If so, you might try the attached patch; if it works, please feel free to install it.

For Clang, it'd probably be better to use -Weverything and then disable
individual warnings with -Wno

I'd rather not spend a lot of time worrying about warnings generated by compilers other than recent GCC, as there are too many compilers and too many false alarms and it's not worth the hassle. If you'd like to take up the burden of pacifying Clang with tricks like the above, though, that should be fine, as long as it doesn't burden maintenance for the rest of us. If not, and if Clang continues to be a hassle, we can avoid much of the hassle by disabling warnings by default when the compiler is Clang.

Attachment: clang.diff
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]