[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fix records hashing (bug#27057, bug#26639)

From: Stefan Monnier
Subject: Re: Fix records hashing (bug#27057, bug#26639)
Date: Wed, 24 May 2017 21:55:13 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux)

>>> -  n = min (SXHASH_MAX_LEN, ASIZE (vec));
>>> +  n = min (SXHASH_MAX_LEN, hash & PSEUDOVECTOR_FLAG ? PVSIZE (vec) : hash);
>> Is this right?  I would have expected
>> hash & PSEUDOVECTOR_FLAG ? PVSIZE (vec) : ASIZE (vec)
   ^^^^                                      ^^^^^^^^^^^

I can see that using `hash` for the ASIZE is slightly confusing (tho
that variable is initialize immediately above), but if so it's also
confusing when doing the "hash & PSEUDOVECTOR_FLAG".


reply via email to

[Prev in Thread] Current Thread [Next in Thread]