[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 941a2e7: todo-mode: don't assume an ordering of tests

From: Stephen Berman
Subject: Re: master 941a2e7: todo-mode: don't assume an ordering of tests
Date: Tue, 30 May 2017 10:58:40 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux)

On Mon, 29 May 2017 20:50:56 -0400 (EDT) address@hidden (Glenn Morris) wrote:

> branch: master
> commit 941a2e7347e3a0d393e67872e6151be8cc66d9a2
> Author: Glenn Morris <address@hidden>
> Commit: Glenn Morris <address@hidden>
>     todo-mode: don't assume an ordering of tests
>     * test/lisp/calendar/todo-mode-tests.el (todo-test-todo-quit02)
>     (todo-test-item-highlighting): Avoid prompting for input file.
> @@ -93,6 +95,7 @@ current again."
>  If the buffer made current by invoking todo-quit in a todo-mode
>  buffer is buried by quit-window, the todo-mode buffer should not
>  become current."
> +  (todo-test-get-archive 2)
>    (todo-show)
>    (should (todo-test-is-current-buffer todo-test-file-1))
>    (let ((dir (dired default-directory)))
> @@ -105,6 +108,7 @@ become current."
>  (ert-deftest todo-test-item-highlighting () ; bug#27133
>    "Test whether `todo-toggle-item-highlighting' highlights whole item.
>  In particular, all lines of a multiline item should be highlighted."
> +  (todo-test-get-archive 2)
>    (todo-show)
>    (todo-jump-to-category nil "testcat1") ; For test rerun.
>    (todo-toggle-item-highlighting)

When I start emacs with -Q, load the test file, and then either run all
tests with `M-x ert RET t RET', or each individually with `M-x ert RET
"todo-test-todo-quit02" RET' etc. in any order, also with reruns, all
tests pass and I get no prompt for a file.  Same when invoking
`emacs -batch -l ert -l /path/to/test/lisp/calendar/todo-mode-tests.el -f
ert-run-tests-batch-and-exit' from the shell.

The tests todo-test-todo-quit02 and todo-test-item-highlighting
shouldn't have any need to display an archive buffer.  How did you run
the tests such that you got prompted for a file and what was the prompt?

Steve Berman

reply via email to

[Prev in Thread] Current Thread [Next in Thread]