[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] master 2349f1d: Turn global-eldoc-mode into a globaliz

From: Dmitry Gutov
Subject: Re: [Emacs-diffs] master 2349f1d: Turn global-eldoc-mode into a globalized minor mode
Date: Wed, 31 May 2017 01:37:17 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Thunderbird/54.0

On 5/30/17 7:09 AM, Stefan Monnier wrote:
     ((memq eldoc-documentation-function '(nil ignore))
+  (unless (memq eldoc-documentation-function '(nil ignore))

It'd probably be best to move this out into its own function so if we
ever change the test at one spot, we also change the other
spot accordingly.

OK, done.

Thinking about this, though, I'm not sure this is ideal.

First, this setup is sensitive to the order in which minor modes are enabled. Which is, in theory, arbitrary.

Second, suppose the user enables an eldoc-enabling-mode manually with 'M-x'. They'll have to 'M-x eldoc-mode' manually afterwards for the desired effect.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]