[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Silence two Clang warnings

From: Paul Eggert
Subject: Re: Silence two Clang warnings
Date: Tue, 13 Jun 2017 13:42:09 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0

Part of the attached patch, recently installed into master, would be automatically reverted the next time we merged from gnulib, since strftime.c is copied from Gnulib. I'm not getting a warning when compiling with Clang, so I'm puzzled as to why the patch was needed. Here's how I build (on Fedora 25):

./configure --enable-gcc-warnings CC=clang

Fedora 25 is running clang version 3.9.1 (tags/RELEASE_391/final).

Background: I would rather avoid the need for this sort of patch, as we shouldn't have to complicate the code just to pacify a Clang false alarm. If an older Clang is generating a false alarm, let's just ignore the diagnostic. If it's a newer Clang, let's change the options to Clang to suppress the diagnostic.

Attachment: 0001-Silence-two-Clang-warnings-by-introducing-additional.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]