[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Update js-mode function heading regexes
|
From: |
Dmitry Gutov |
|
Subject: |
Re: [PATCH] Update js-mode function heading regexes |
|
Date: |
Mon, 19 Jun 2017 02:59:01 +0300 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Thunderbird/54.0 |
Hi!
On 6/17/17 10:30 AM, Adam Niederer wrote:
Below is the file I used to test these changes. make check is failing
for me, but it looks like the failing tests are unrelated (filenotify &
inotify).
These are manual tests, right? 'make check' doesn't sound relevant.
But we have some automated tests for js.el too. Check out
test/lisp/progmodes/js-tests.el. Maybe these scenarios would be better
coded with ERT.
This is my first contribution via a mailing list, so please let me know
if I'm missing anything :).
Not much. Patch submissions via the bug tracker have higher odds of not
being forgotten is they're not applied right away, though.
Thanks for the patch.