[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: libnettle/libhogweed WIP
From: |
Eli Zaretskii |
Subject: |
Re: libnettle/libhogweed WIP |
Date: |
Wed, 28 Jun 2017 19:54:38 +0300 |
> From: Ted Zlatanov <address@hidden>
> Date: Tue, 27 Jun 2017 18:58:30 -0400
>
> There is only one major TODO I can't resolve: I asked for help before,
> and still can't make the autoconf code detect the GnuTLS functions
> individually.
Doesn't something like AC_CHECK_FUNCS do the job? If not, why not?
(In general, the Autoconf manual should be able to answer these
questions.)
> The other TODO below maybe can be answered here? Should I remove it or
> leave it?
>
> // TODO: switch this to use a resize_string_data() function when
> // that's provided in the C core, to avoid the extra copy.
Remove it.
> EZ> You don't need a 'return' after calling 'error' (here and elsewhere),
> EZ> as the latter doesn't return.
>
> I got warnings for it in a few places so I added those returns
> consistently.
Which warnings and at what places?
If the function doesn't return, it should be marked _Noreturn, as we
do in other places. Maybe that was your original problem.
> I removed them, but it's not my favorite thing to omit the braces,
> especially in the
>
> if a
> b
> else if c
> d
> else
> e
>
> situation. Do you think I should reintroduce them in those places?
We don't use braces in such situations, unless there are comments that
make the blocks larger than 1 line.