[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Why does make run git?

From: Richard Stallman
Subject: Re: Why does make run git?
Date: Tue, 01 Aug 2017 10:30:36 -0400

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > > git config transfer.fsckObjects 'true'

  > This makes Git abort if it sees a bad object being pulled or pushed.

Isn't that a personal preference?  It seems wrong for Emacs to set it

  > > git config diff.elisp.xfuncname 
  > > git config diff.m4.xfuncname '^((m4_)?define|A._DEFUN(_ONCE)?)\([^),]*'
  > > git config diff.make.xfuncname 
'^([$.[:alnum:]_].*:|[[:alnum:]_]+[[:space:]]*([*:+]?[:?]?|!?)=|define .*)'
  > > git config diff.shell.xfuncname 
  > > git config diff.texinfo.xfuncname 

  > These tailor the Git's notion of a "function" for the various
  > languages.  It's handy in several commands that need to know where a
  > function begins and ends.

Do you mean, several Git commands, or several Emacs commands?
I would guess it is the former.

Running make on the Emacs checkout seems like an inadequate place to
do this.  There is no assurance that you will run make in that
checkout before committing anything.

Perhaps there should be a function in Emacs that does this, and some
VC commands could call it.

  > > Installing git hooks...
  > > ‘build-aux/git-hooks/commit-msg’ -> ‘.git/hooks/commit-msg’
  > > ‘build-aux/git-hooks/pre-commit’ -> ‘.git/hooks/pre-commit’
  > > ‘.git/hooks/applypatch-msg.sample’ -> ‘.git/hooks/applypatch-msg’
  > > ‘.git/hooks/pre-applypatch.sample’ -> ‘.git/hooks/pre-applypatch’

  > These hooks check the format of the commits and verify it is
  > according to our standards.

Running make on Emacs seems like an unreliable place to do this,
because there is no assurance that you will run make in that checkout
before committing anything.

Dr Richard Stallman
President, Free Software Foundation (gnu.org, fsf.org)
Internet Hall-of-Famer (internethalloffame.org)
Skype: No way! See stallman.org/skype.html.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]