[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Question about test failure on Hydra

From: Stephen Berman
Subject: Re: Question about test failure on Hydra
Date: Sat, 05 Aug 2017 23:34:25 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)

On Sat, 05 Aug 2017 22:07:38 +0900 Tino Calancha <address@hidden> wrote:

> Tino Calancha <address@hidden> writes:
>> On Tue, 1 Aug 2017, Stephen Berman wrote:
>>> On Tue, 01 Aug 2017 13:39:50 +0900 Tino Calancha <address@hidden> wrote:
>>>> Stephen Berman <address@hidden> writes:
>>>>> On Mon, 31 Jul 2017 06:26:55 +0300 Eli Zaretskii <address@hidden> wrote:
>>>>> (dired test-dir) reverts an existing Dired buffer, because of setting
>>>>> dired-auto-revert-buffer to t.  (When I step through the code, it is
>>>>> after reverting that point moves to the subdirectory line, which the
>>>>> should make "sanity check" true (and does, both when I step through the
>>>>> code and just run the test in any way).  When I comment out the
>>>>> dired-auto-revert-buffer line, then point stays at point-min, which
>>>>> makes the sanity check fail (dired-file-name-at-point returns nil),
>>>> When i comment out i see the point in point-max, and the test fails
>>>> same as you but: (dired-file-name-at-point returns nil)
>>>>> though not in the way Hydra reports (it shows point being on the ".."
>>>>> entry).)
>>>> If somehow, we have in such Dired buffer the point at ".." _before_
>>>> call `dired-revert', then _after_ revert the point is preserved:
>>> Yes, but the question is, how does point get there in Hydra?
> I got the answer: because the Dired header line changed its size.
> *) Before revert, it looks like:
> "  total used in directory 8 available 37449484"
> **) After revert, it changed to something like:
> "  total used in directory 12 available 37449480"
> ;; 1 char longer: that mess up the saved position.
> (See http://debbugs.gnu.org/27968).

Very well spotted!  And your fix LGTM too.

>> That's 1 million dollard question
> I want my million bucks in a bag in the usual place; please, in small
> bills.  No cops.

I'm afraid I only have very small bags, so it will take about a million

Steve Berman

reply via email to

[Prev in Thread] Current Thread [Next in Thread]