[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: HiDPI support for wave style underlines

From: Yuri D'Elia
Subject: Re: HiDPI support for wave style underlines
Date: Mon, 21 Aug 2017 14:20:56 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux)

On Fri, Aug 18 2017, Eli Zaretskii wrote:
>> Good point regarding the emacs_abort(), I honestly didn't think through that.
>> I have modified x_get_scale_factor to return a new struct
>> x_display_scale with x and y components which are used in the wave
>> length and height calculation.
>> Indentations and comment grammar have been fixed up as well.
> Sorry for the long delay.
> Thanks, I pushed this with minor changes.  Specifically, the function
> you added is only used in the same file where it is defined, so it
> should be static and its prototype doesn't need to be in xterm.h.
> Also, for returning just 2 values, it is better to provide 2 pointer
> arguments than to invent a new struct.

I actually get a floating point exception with this since I rebuilt
emacs on the 19th. I'm rebuilding emacs now with debug to check where
it's located, but I pinpointed it to flyspell so...

reply via email to

[Prev in Thread] Current Thread [Next in Thread]