Re: [Emacs-diffs] master da3e101: ; Try not to affect match data

[Mark Oteiza]

On 07/09/17 at 08:16pm, Stefan Monnier wrote:
> >     ; Try not to affect match data
> >     * lisp/xdg.el (xdg-user-dir): Use save-match-data.
>
> Why does it matter?  Given the general way we handle match-data,
> I think it's a bug for Elisp code to assume that something like
> xdg-user-dir won't affect the match data.

I guess it doesn't--I can take it out.

> PS: And I just saw that the code says
>
>   "Return the path of user directory referred to by NAME."
>
>   which is wrong since the GNU convention is to use "path" only for
>   lists of directories (as in $PATH, $MANPATH, load-path, ...), so it
>   should say something like "file name" or just "Return the directory
>   referred to by NAME"

OK, I'll reword it, thanks.