[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Emacs26: Quick thoughts on display-line-numbers-mode
From: |
Matthew Plant |
Subject: |
Re: Emacs26: Quick thoughts on display-line-numbers-mode |
Date: |
Fri, 6 Oct 2017 00:50:10 -0700 |
Yes, I should have read the comment literally right above the line I suggested
changing.
I didn’t mean to offer that snippet as a solution, just as a suggestion for
anyone compiling themselves. I would be more formal otherwise.
If I understand the problem correctly, since orientation depends on paragraph,
does that mean line numbers could be on different sides in the same window?
I think I have an approach for fixing this
> On Oct 6, 2017, at 12:26 AM, Eli Zaretskii <address@hidden> wrote:
>
>> From: Matthew Plant <address@hidden>
>> Cc: address@hidden
>> Date: Thu, 05 Oct 2017 20:09:39 -0700
>>
>>> There's a technical problem with doing that, for which I didn't have
>>> a
>>> solution at the time and still don't. Such an option would also slow
>>> redisplay, albeit in minor ways.
>>>
>> For now, you can go to src/xdisp.c:20996 and change the line:
>> strcat (lnum_buf, " ");
>> to
>> strcat (lnum_buf, "|");
>
> The problem with this is that in R2L paragraphs the glyph should
> _precede_ the number, i.e. be to the left of the number. And when the
> number is generated for the first line to be redrawn, the paragraph
> direction was not yet computed. This is the technical problem to
> which I alluded. Until I find a way to solve it, such solutions
> cannot be accepted, sorry.
>
>> Although I think I like the pipe character better than the space.
>
> That definitely depends on the font you are using. Some fonts have an
> extremely ugly pipe glyphs. So this will have to be another
> customization option, not just a hard-coded character.
- Emacs26: Quick thoughts on display-line-numbers-mode, Robert Weiner, 2017/10/05
- Re: Emacs26: Quick thoughts on display-line-numbers-mode, Eli Zaretskii, 2017/10/05
- Re: Emacs26: Quick thoughts on display-line-numbers-mode, Robert Weiner, 2017/10/05
- Re: Emacs26: Quick thoughts on display-line-numbers-mode, Eli Zaretskii, 2017/10/05
- Re: Emacs26: Quick thoughts on display-line-numbers-mode, Robert Weiner, 2017/10/05
- Re: Emacs26: Quick thoughts on display-line-numbers-mode, Matthew Plant, 2017/10/05
- Re: Emacs26: Quick thoughts on display-line-numbers-mode, Eli Zaretskii, 2017/10/06
- Re: Emacs26: Quick thoughts on display-line-numbers-mode,
Matthew Plant <=
- Re: Emacs26: Quick thoughts on display-line-numbers-mode, Eli Zaretskii, 2017/10/06
- Re: Emacs26: Quick thoughts on display-line-numbers-mode, Stefan Monnier, 2017/10/06
- Re: Emacs26: Quick thoughts on display-line-numbers-mode, Eli Zaretskii, 2017/10/06
- Re: Emacs26: Quick thoughts on display-line-numbers-mode, John Wiegley, 2017/10/06
- Re: Emacs26: Quick thoughts on display-line-numbers-mode, Eli Zaretskii, 2017/10/06
- Re: Emacs26: Quick thoughts on display-line-numbers-mode, John Wiegley, 2017/10/06
Re: Emacs26: Quick thoughts on display-line-numbers-mode, Matthew Plant, 2017/10/05