[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Saving match data

From: Philipp Stephani
Subject: Re: Saving match data
Date: Sun, 08 Oct 2017 15:56:52 +0000

Philipp Stephani <address@hidden> schrieb am Sa., 17. Juni 2017 um 16:02 Uhr:
Stefan Monnier <address@hidden> schrieb am Sa., 17. Juni 2017 um 15:53 Uhr:
> +            (when (or (function-get function 'pure)
> +                      (function-get function 'side-effect-free))
> +              (insert "\nThis function does not change the match data."))

Wouldn't it be more useful to say it doesn't have side-effects (which
would obviously imply it doesn't change the match-data, along with all
other global state)?

I'd prefer to mention the match data explicitly, because users might not be aware that they are part of the global state. Maybe something like "This function does not (access|change) global state, including the match data" (where "access" can be used for the pure ones). 

Given there were no more comments, I've pushed the patch (with the changed wording) to master as f4995e7d36. 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]