[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: JSON/YAML/TOML/etc. parsing performance

From: Eli Zaretskii
Subject: Re: JSON/YAML/TOML/etc. parsing performance
Date: Sun, 08 Oct 2017 21:42:33 +0300

> From: Philipp Stephani <address@hidden>
> Date: Sun, 08 Oct 2017 17:58:14 +0000
> Cc: address@hidden
>  I've attached a new patch (which currently segfaults on decode_coding_gap, 
> but the call to that function
> doesn't seem to be required anyway). 

I think decode_coding_gap might segfault because you use insert_1_both
to put the text into the buffer.  By contrast, decode_coding_gap
assumes you've copied the bytes into the gap, like we do in

I don't think we can bypass decoding in this case; the reason why you
think it isn't needed is because you only tried that with valid UTF-8
encoded text.  We never rely on that elsewhere, AFAIK.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]