[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Flymake refactored
From: |
João Távora |
Subject: |
Re: Flymake refactored |
Date: |
Tue, 10 Oct 2017 16:20:33 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) |
Mark Oteiza <address@hidden> writes:
> On 09/10/17 at 12:21am, João Távora wrote:
>> Feel free to tweak again and push to the
>> scratch/flymake-diagnostics-buffer branch.
>
> I just added the keymap to the button--did not notice anything else
> wrong with it.
Remarkably, this breaks the button (at least in my testing) for
mouse-clicks, which is the only reason it is there. Being a button I
think one shouldn't mess with its keymap.
Rather, this is what is needed unbreak RET on the button (and still keep
mouse-1, mouse-2 and SPC, naturally)
diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
index cf1e7e41ba..e4c6a38a77 100644
--- a/lisp/progmodes/flymake.el
+++ b/lisp/progmodes/flymake.el
@@ -1132,7 +1132,7 @@ flymake--diagnostics-buffer-entries
mouse-face highlight
help-echo "mouse-2: visit this diagnostic"
face nil
- keymap flymake-diagnostics-buffer-mode-map
+ action flymake-goto-diagnostic
mouse-action flymake-goto-diagnostic)]))))
(define-derived-mode flymake-diagnostics-buffer-mode tabulated-list-mode
João
- Re: Flymake refactored, (continued)
- Re: Flymake refactored, Stefan Monnier, 2017/10/07
- Re: Flymake refactored, João Távora, 2017/10/07
- Re: Flymake refactored, João Távora, 2017/10/07
- Re: Flymake refactored, Mark Oteiza, 2017/10/07
- Re: Flymake refactored, João Távora, 2017/10/08
- Re: Flymake refactored, Mark Oteiza, 2017/10/08
- Re: Flymake refactored, João Távora, 2017/10/08
- Re: Flymake refactored, Mark Oteiza, 2017/10/10
- Re: Flymake refactored,
João Távora <=
- Re: Flymake refactored, Mark Oteiza, 2017/10/10
- Re: Flymake refactored, Lele Gaifax, 2017/10/05
- Re: Flymake refactored, Lele Gaifax, 2017/10/05
Re: Flymake refactored, Lele Gaifax, 2017/10/10