emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master f79c33b 3/3: Use special-mode for read-only buffers.


From: Sam Steingold
Subject: Re: master f79c33b 3/3: Use special-mode for read-only buffers.
Date: Fri, 24 Nov 2017 14:26:41 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (darwin)

> * Glenn Morris <address@hidden> [2017-11-24 13:29:39 -0500]:
>
> Sam Steingold wrote:
>
>> branch: master
>> commit f79c33b39f195d1b30d7a3e085804e45ab76358e
>
>>     Use special-mode for read-only buffers.
>>     
>>     * lisp/progmodes/etags.el (tags-table-mode): Define using
>>     `define-derived-mode', inheriting from `special-mode'.
>>     Not only the buffer is now read-only, but you can bury it with "q".
>>     (select-tags-table-mode): No need to set `buffer-read-only'
>>     explicitly, `special-mode' takes care of that.
>
> This change causes a test failure.
> Ref: https://hydra.nixos.org/build/64565487
>
>   (user-error ("File /build/emacs-27.0.50/test/manual/etags/ETAGS.good_1
> is not a valid tags table"))

Oops.
I think I know the reason for the failure and I just pushed a fix.
Thanks!

-- 
Sam Steingold (http://sds.podval.org/) on darwin Ns 10.3.1504
http://steingoldpsychology.com http://www.childpsy.net 
http://honestreporting.com
http://memri.org http://www.dhimmitude.org http://iris.org.il http://jij.org
Live Lisp and prosper.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]