emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Use get_key_arg to parse keyword arguments in json_parse_obj


From: Paul Eggert
Subject: Re: [PATCH] Use get_key_arg to parse keyword arguments in json_parse_object_type
Date: Tue, 26 Dec 2017 11:11:12 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0

John Wiegley wrote:
I approve of the patch, Vibhav. I'm suprised we don't have a SAFE_CALLOC
macro, though, to avoid having to use memset immediately after.

I guess Vibhav's future patches will make this issue moot, as the change doesn't make sense by itself; it merely substitutes a less-efficient implementation for a more-efficient one. Perhaps Vibhav's future changes will pass the argument without memsetting it, for example.

It would be helpful to know what the future changes are, as it's hard to tell whether the proposed patch is a good idea without seeing it in the context of the future patches.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]