[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Make byte-compile-error-on-warn a safe variable for file com
From: |
Noam Postavsky |
Subject: |
Re: [PATCH] Make byte-compile-error-on-warn a safe variable for file compilation |
Date: |
Wed, 10 Jan 2018 14:44:59 -0500 |
On Wed, Jan 10, 2018 at 2:36 PM, Eli Zaretskii <address@hidden> wrote:
>> From: Noam Postavsky <address@hidden>
>> Date: Wed, 10 Jan 2018 11:29:45 -0500
>> Cc: Stefan Monnier <address@hidden>, Emacs developers <address@hidden>
>>
>> >> Since this autoload vs :safe property consideration applies more
>> >> generally, shouldn't we rather explain in it in the manual?
>> >
>> > I think we should do both. The fact that some unusual technique is in
>> > the manual doesn't yet mean commentary about it will be redundant.
>>
>> But there are many other cases of this autoloaded put, should we
>> comment on all of them?
>
> Maybe we should do that on more than just this one. But even a
> thousand-mile journey begins with a single step.
>
> Did you never have this moment of staring at a piece of code that
> doesn't explain itself and has no comments, and wondering why the heck
> did they do it that way? It is not easy to find answers to such
> questions, even if they are in some manual.
To me, this looks like it should be considered a standard technique,
that we shouldn't need to explain over and over again (but currently
it's not even explained once in the manual, which is not good).
- Re: [PATCH] Make byte-compile-error-on-warn a safe variable for file compilation, (continued)
- Re: [PATCH] Make byte-compile-error-on-warn a safe variable for file compilation, Noam Postavsky, 2018/01/08
- Re: [PATCH] Make byte-compile-error-on-warn a safe variable for file compilation, Eli Zaretskii, 2018/01/08
- Re: [PATCH] Make byte-compile-error-on-warn a safe variable for file compilation, Robert Cochran, 2018/01/08
- Re: [PATCH] Make byte-compile-error-on-warn a safe variable for file compilation, Stefan Monnier, 2018/01/09
- Re: [PATCH] Make byte-compile-error-on-warn a safe variable for file compilation, Robert Cochran, 2018/01/10
- Re: [PATCH] Make byte-compile-error-on-warn a safe variable for file compilation, Eli Zaretskii, 2018/01/10
- Re: [PATCH] Make byte-compile-error-on-warn a safe variable for file compilation, Noam Postavsky, 2018/01/10
- Re: [PATCH] Make byte-compile-error-on-warn a safe variable for file compilation, Eli Zaretskii, 2018/01/10
- Re: [PATCH] Make byte-compile-error-on-warn a safe variable for file compilation, Noam Postavsky, 2018/01/10
- Re: [PATCH] Make byte-compile-error-on-warn a safe variable for file compilation, Eli Zaretskii, 2018/01/10
- Re: [PATCH] Make byte-compile-error-on-warn a safe variable for file compilation,
Noam Postavsky <=
- Re: [PATCH] Make byte-compile-error-on-warn a safe variable for file compilation, Eli Zaretskii, 2018/01/10