[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: wait_reading_process_ouput hangs in certain cases (w/ patches)
From: |
Eli Zaretskii |
Subject: |
Re: wait_reading_process_ouput hangs in certain cases (w/ patches) |
Date: |
Fri, 16 Feb 2018 18:01:38 +0200 |
> Cc: address@hidden
> From: Matthias Dahl <address@hidden>
> Date: Tue, 13 Feb 2018 15:25:44 +0100
>
> after some unexpected / unintended prolonged delay due to personal
> reasons, for which I apologize, attached the v2 of my patches.
>
> Basically I have gone a somewhat different route. While working in
> some of the requested changes, I noticed that there were still some
> pathological cases that were not covered and fixing that would make
> things even more convoluted.
>
> So, in this version, the return value is calculated (if necessary)
> strategically right before we return from the function call, thus it
> cannot be missed and we will always properly signal if data was read
> from a wait_proc (either directly or indirectly).
>
> And instead of messing with got_some_output, we exit the loop when we
> got some data (directly or indirectly) for our wait_proc if there is
> no data to be read for this iteration. This leaves the whole function
> logic alone -- except for this key point.
>
> I have addressed the remaining issues, if they still applied. And I
> have not been able to trigger a single hang with these patches.
>
> I appreciate any comments and suggestions.
Thanks for your work and perseverance. I've now pushed this to the
master branch.
- Re: wait_reading_process_ouput hangs in certain cases (w/ patches), Matthias Dahl, 2018/02/13
- Re: wait_reading_process_ouput hangs in certain cases (w/ patches), Paul Eggert, 2018/02/13
- Re: wait_reading_process_ouput hangs in certain cases (w/ patches),
Eli Zaretskii <=
- Re: wait_reading_process_ouput hangs in certain cases (w/ patches), Lars Ingebrigtsen, 2018/02/16
- Re: wait_reading_process_ouput hangs in certain cases (w/ patches), Lars Ingebrigtsen, 2018/02/16
- Re: wait_reading_process_ouput hangs in certain cases (w/ patches), andres . ramirez, 2018/02/22
- Re: wait_reading_process_ouput hangs in certain cases (w/ patches), Matthias Dahl, 2018/02/26
- Re: wait_reading_process_ouput hangs in certain cases (w/ patches), andrés ramírez, 2018/02/26
- Re: wait_reading_process_ouput hangs in certain cases (w/ patches), Lars Ingebrigtsen, 2018/02/26
- Re: wait_reading_process_ouput hangs in certain cases (w/ patches), andrés ramírez, 2018/02/26
- Re: wait_reading_process_ouput hangs in certain cases (w/ patches), Daniel Colascione, 2018/02/26
- Re: wait_reading_process_ouput hangs in certain cases (w/ patches), andrés ramírez, 2018/02/26
- Re:, Daniel Colascione, 2018/02/26