[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: nxml-mode: consider changing nxml-sexp-element-flag default
From: |
Eli Zaretskii |
Subject: |
Re: nxml-mode: consider changing nxml-sexp-element-flag default |
Date: |
Sun, 01 Apr 2018 12:50:27 +0300 |
> From: Jostein Kjønigsen <address@hidden>
> Date: Tue, 20 Mar 2018 07:18:49 +0100
>
> On Mon, Mar 19, 2018, at 10:03 PM, Stefan Monnier wrote:
>
> In case there's no objections and we decide to go through with this,
> I've change the default and run "make check".
> It seems no tests are impacted, and the patch is therefore pretty small.
> Is there anything more we'll need to do?
>
> Mention the change in etc/NEWS ?
>
> Stefan
>
> Sounds reasonable. Fixed.
Thanks, I pushed this to the master branch.
For the future, please take care of the following nits:
. include a ChangeLog-style commit log message with your changes
. mark entries in NEWS with "---" if they need no documentation
updates, "+++" if the documentation updates are included in the
patch or were already done in the past
. review references to the variable(s) whose default(s) you are
changing, and amend the references as needed; e.g., if some doc
string describes what happens "by default", it will need to be
amended to describe the new default.
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: nxml-mode: consider changing nxml-sexp-element-flag default,
Eli Zaretskii <=