[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] master 7cfe2dc: In edebug in GUIs, move focus to the s
From: |
Alan Mackenzie |
Subject: |
Re: [Emacs-diffs] master 7cfe2dc: In edebug in GUIs, move focus to the selected frame. |
Date: |
Fri, 19 Oct 2018 18:49:17 +0000 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
Hello, Stefan.
On Fri, Oct 19, 2018 at 13:58:44 -0400, Stefan Monnier wrote:
> Hi Alan,
> > (edebug-pop-to-buffer edebug-buffer)
> > + (edebug-focus-frame (window-frame (selected-window)))
> [...]
> > - (edebug-pop-to-buffer edebug-buffer (car edebug-window-data)))))
> > + (edebug-pop-to-buffer edebug-buffer (car edebug-window-data))
> > + (edebug-focus-frame (window-frame (selected-window))))))
> [...]
> > - (edebug-pop-to-buffer edebug-eval-buffer))
> > + (edebug-pop-to-buffer edebug-eval-buffer)
> > + (edebug-focus-frame (window-frame (selected-window))))
> Maybe edebug-pop-to-buffer should call edebug-focus-frame?
I thought about that, but in the end decided that could be a bit heavy
for when information is only being displayed, i.e. in
edebug-trace-display. Maybe putting the call in e-pop-to-buffer would
indeed be better. But I think edebug-trace-display would have then to
call edebug-focus-frame explicitly after re-selecting the original
window.
This bit of the code surely originates from the time before frames were
implemented.
> Stefan
--
Alan Mackenzie (Nuremberg, Germany).