[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Remove trailing whitespace from bookmark.el coding cookie
From: |
Karl Fogel |
Subject: |
Re: Remove trailing whitespace from bookmark.el coding cookie |
Date: |
Mon, 19 Nov 2018 11:26:44 -0600 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Robert Pluim <address@hidden> writes:
>Thereʼs a trailing space in the coding cookie that bookmark.el writes
>to bookmark files, which is allowed but not required by the format,
>but makes my git commit hooks complain. Any objections to me
>installing the following on master?
Sounds good to me. The extra space is clearly accidental -- other similar
lines in the Emacs source code don't have a space there.
Best regards,
-Karl
>modified lisp/bookmark.el
>@@ -734,7 +734,7 @@ bookmark-insert-file-format-version-stamp
> (if (memq (coding-system-base coding) '(undecided prefer-utf-8))
> (setq coding 'utf-8-emacs))
> (insert
>- (format ";;;; Emacs Bookmark Format Version %d ;;;; -*- coding: %S -*- \n"
>+ (format ";;;; Emacs Bookmark Format Version %d ;;;; -*- coding: %S -*-\n"
> bookmark-file-format-version (coding-system-base coding)))
> (insert ";;; This format is meant to be slightly human-readable;\n"
> ";;; nevertheless, you probably don't want to edit it.\n"