Re: No support for ImageMagick 7 in emacs-26

[Eli Zaretskii]

> From: Ulrich Mueller <address@hidden>
> Cc: address@hidden
> Date: Mon, 26 Nov 2018 23:00:48 +0100
> 
> We could put a conditional around it (but it looks silly):
> 
> #ifdef HAVE_IMAGEMAGICK7
>       double quantum_range = QuantumRange;
>       MagickRealType color_scale = 65535.0 / quantum_range;
> #else
>       MagickRealType color_scale = 65535.0 / QuantumRange;
> #fi
> 
> > (why is it needed, anyway?).
> 
> According to the commit message (commit 42ed35c68b):
>     
>     * src/image.c (imagemagick_load_image): Use double division, and
>     eliminate a cast.  This avoids a -Wdouble-promotion warning with
>     GCC 7.3 on Ubuntu 18.04.

So it's not really related to ImageMagick 7 support, right?

> IMHO it would be shortsighted to support only a version that ImageMagick
> upstream considers legacy.

I may be shortsighted, but I'm not against adding v7 support, if it is
done safely, as Emacs 26.2 is supposed to be more stable than 26.1,
not less stable.

Thanks.