Re: [Emacs-diffs] master 1691a51: * lisp/emacs-lisp/map.el: Make the functions generic

[Stefan Monnier]

> Why not continue to check whether lists are null, rather than traversing
> their entire length:
>
>   (cl-defmethod map-empty-p ((map list))
>     (null map))

Indeed, thanks.  Could you install this change?

>> +(cl-defmethod map-contains-key ((map list) key &optional testfn)
>> +  (alist-get key map nil nil (or testfn #'equal)))
> I think this should get the same treatment as the hash table method,
> which checks whether DEFAULT was returned:

Same here (actually, this one was a thinko: for some reason I wrote the
code assuming alist-get would behave like assoc and return the cons
cell).


        Stefan